Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amanda - Media Ranker Revisited #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Amanda - Media Ranker Revisited #36

wants to merge 1 commit into from

Conversation

amandaungco
Copy link

No description provided.

@CheezItMan
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController The tests for upvote are empty and you have no tests which involve guest users and authenticated users!.
Appropriate Tests on SessionsController NO TESTING
Appropriate Tests on UsersController NO TESTING
Completed OAuth INCOMPLETE
Overall I'll be frank, this is pretty disappointing, You didn't include the Gem or the .env data to run OAuth, and your testing was sparse. I would very much like you to go the extra mile in Api-Muncher and have OAuth working on it, just to verify you are able to do it. It will be your last chance at Ada to build a Rails app that could do so.

CheezItMan
CheezItMan reviewed Oct 31, 2018
View reviewed changes
test/controllers/works_controller_test.rb
# Precondition: there is at least one media in two of the categories

end

it "succeeds with no media" do
works.each do |work|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be done with Work.destroy_all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amandaungco @CheezItMan